Separate slow CI job to it's own workflow

[tunetheweb]

Brief summary of the change made

When GitHub Actions or Coverage experiences issues (as they are want to do!) we sometimes have to rerun the CI jobs. The Critical Rules Test is slow to run, but doesn't impact Coverage, so separate that out to it's own job so it doesn't need to be rerun if it passes.

Are there any other side effects of this change that we should be aware of?

Nope.

Pull Request checklist

• Please confirm you have completed any of the necessary steps below.

• Included test cases to demonstrate any code changes, which may be one or more of the following:

  • .yml rule test cases in test/fixtures/rules/std_rule_cases.
  • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
  • Full autofix test cases in test/fixtures/linter/autofix.
  • Other.

• Added appropriate documentation for the change.

• Created GitHub issues for any relevant followup/future enhancements if appropriate.

[codecov]

Codecov Report

Merging #3012 (05e3509) into main (fc22204) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main     #3012   +/-   ##
========================================
  Coverage   99.99%   100.00%           
========================================
  Files         164       164           
  Lines       11997     11997           
========================================
+ Hits        11996     11997    +1     
+ Misses          1         0    -1     

Impacted Files	Coverage Δ
src/sqlfluff/core/templaters/jinja.py	100.00% <0.00%> (+0.59%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc22204...05e3509. Read the comment docs.

[pwildenhain]

Super sensible 👍🏻

[barrywhart]

Since it's running on a schedule, how will we be alerted if it fails? Email?

[tunetheweb]

The GitHub altering on scheduled runs is a bit lacking to be honest. Long been complained about: https://git.luolix.topmunity/t/no-email-notification-on-schedule-cron-job-failure/119638/5

I think only the last person to alter it (me!) gets a notification. Which sucks to be honest.

Now to be honest this cron job isn’t really needed. I like it in case there is no activity on repo for a while (not something we have a problem with!!) so can see when something broke if, for example, dependencies update.