Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Db2 dialect #3231

Merged
merged 8 commits into from
May 2, 2022
Merged

Conversation

ddresslerlegalplans
Copy link
Contributor

@ddresslerlegalplans ddresslerlegalplans commented Apr 29, 2022

Brief summary of the change made

Fixes #3229

Are there any other side effects of this change that we should be aware of?

Not that I am aware of

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Please confirm you have completed any of the necessary steps below.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/fixtures/dialects/db2fori/.sqlfluff Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ddresslerlegalplans ddresslerlegalplans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I've addressed all issues. Let me know if I need to squash commits and rename the first commit from "Add Db2 for i dialect" to "Add Db2 dialect"

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/fixtures/dialects/db2fori/.sqlfluff Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

Let me know if I need to squash commits and rename the first commit from "Add Db2 for i dialect" to "Add Db2 dialect"

No need as we squash on merge. In fact we prefer you NOT to squash commits in case we want to see what’s changed since last time we viewed.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Couple of suggested changes.

Also could you update the main README.md to list this as a dialect too?

README.md Outdated Show resolved Hide resolved
docs/source/dialects.rst Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

Also looks like you need to run black.

This can be done automatically for changed files on commit using pre-commit: https://github.com/sqlfluff/sqlfluff/blob/main/CONTRIBUTING.md#pre-commit-config

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #3231 (4cac2d0) into main (5efff59) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          166       167    +1     
  Lines        12417     12423    +6     
=========================================
+ Hits         12417     12423    +6     
Impacted Files Coverage Δ
src/sqlfluff/core/dialects/__init__.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_db2.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5efff59...4cac2d0. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me. You happy to merge now or still working on other changes?

@ddresslerlegalplans
Copy link
Contributor Author

I'm happy with a merge now. Thanks again for the help and review.

@ddresslerlegalplans ddresslerlegalplans changed the title WIP DO NOT MERGE: Add Db2 for i dialect Add Db2 for i dialect May 2, 2022
@tunetheweb tunetheweb changed the title Add Db2 for i dialect Add Db2 dialect May 2, 2022
@tunetheweb tunetheweb merged commit f2db37a into sqlfluff:main May 2, 2022
@tunetheweb
Copy link
Member

I'm happy with a merge now. Thanks again for the help and review.

Thank YOU for working in this!

@tunetheweb
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Db2 for i dialect
2 participants