-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Db2 dialect #3231
Add Db2 dialect #3231
Conversation
test/fixtures/dialects/db2fori/create_table_field_name_with_pound_sign.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I've addressed all issues. Let me know if I need to squash commits and rename the first commit from "Add Db2 for i dialect" to "Add Db2 dialect"
test/fixtures/dialects/db2fori/create_table_field_name_with_pound_sign.yml
Outdated
Show resolved
Hide resolved
No need as we squash on merge. In fact we prefer you NOT to squash commits in case we want to see what’s changed since last time we viewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Couple of suggested changes.
Also could you update the main README.md to list this as a dialect too?
Also looks like you need to run This can be done automatically for changed files on commit using pre-commit: https://github.com/sqlfluff/sqlfluff/blob/main/CONTRIBUTING.md#pre-commit-config |
Codecov Report
@@ Coverage Diff @@
## main #3231 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 166 167 +1
Lines 12417 12423 +6
=========================================
+ Hits 12417 12423 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me. You happy to merge now or still working on other changes?
I'm happy with a merge now. Thanks again for the help and review. |
Thank YOU for working in this! |
Brief summary of the change made
Fixes #3229
Are there any other side effects of this change that we should be aware of?
Not that I am aware of
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Please confirm you have completed any of the necessary steps below.
Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.