Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional AS in MERGE statements using SELECT #3276

Merged
merged 2 commits into from
May 6, 2022

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #3270

Are there any other side effects of this change that we should be aware of?

Nope

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #3276 (277dbf1) into main (99cc8a5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          167       167           
  Lines        12627     12627           
=========================================
  Hits         12627     12627           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cc8a5...277dbf1. Read the comment docs.

@tunetheweb tunetheweb merged commit 3de1291 into sqlfluff:main May 6, 2022
@tunetheweb tunetheweb deleted the 3270-merge-select-optional-as branch May 6, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: MERGE statements without source alias are unparsable
2 participants