Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres: Finish ALTER TYPE #3451

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

greg-finley
Copy link
Contributor

Brief summary of the change made

Closes #3449

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though looking at the docs I think there’s a few more:

  • RENAME ATTRIBUTE
  • DROP ATTRIBUTE
  • ALTER ATTRIBUTE

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3451 (3019f82) into main (d109072) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          170       170           
  Lines        12884     12884           
=========================================
  Hits         12884     12884           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d109072...3019f82. Read the comment docs.

@greg-finley
Copy link
Contributor Author

LGTM though looking at the docs I think there’s a few more:

  • RENAME ATTRIBUTE
  • DROP ATTRIBUTE
  • ALTER ATTRIBUTE

Whoops, will add those.

@greg-finley greg-finley requested a review from tunetheweb June 13, 2022 20:47
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tunetheweb tunetheweb merged commit 50eea8e into sqlfluff:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres: ALTER TYPE (name) ADD VALUE throws PRS (Found unparsable section)
2 participants