Clickhouse: allow FINAL modifier
#3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomAub
force-pushed
the
thomaub/clickhouse-3507-final-modifier
branch
from
b900f0a to
bf76043
Compare
tunetheweb
changed the title
FINAL modifier
Codecov Report
@@ Coverage Diff @@
## main #3534 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 172 172
Lines 13047 13050 +3
=========================================
+ Hits 13047 13050 +3
Continue to review full report at Codecov.
|
tunetheweb
requested changes
Jul 1, 2022
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #3507
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate. ClickHouse dialect does not support final modifier #3507