Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude .coverage.py from linting #3564

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

zidder
Copy link
Contributor

@zidder zidder commented Jul 6, 2022

Brief summary of the change made

fixes #3563
Because of the .coverage.py file, the linting raised this kind of error:

ValueError: source code string cannot contain null bytes
ERROR: InvocationError for command /home/zidder/pythonTricks/sqlfluff/.tox/linting/bin/flake8 (exited with code 1)

Now this error is gone, because the .coverage.py is not linted anymore.

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #3564 (6a236fa) into main (b1a13a5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3564   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines        13083     13083           
=========================================
  Hits         13083     13083           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a13a5...6a236fa. Read the comment docs.

Copy link
Member

@barrywhart barrywhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the fix!

@barrywhart barrywhart merged commit bbdf12c into sqlfluff:main Jul 6, 2022
@zidder zidder deleted the fix_tox branch July 7, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting doesn't work after testing
2 participants