-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source fixing capability and fix routines for L046 #3578
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3578 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 174 174
Lines 13149 13205 +56
=========================================
+ Hits 13149 13205 +56
Continue to review full report at Codecov.
|
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
I'll try and review tonight. We're on vacation this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I've thought about this for a while, but you made it happen. 💪 🎉
This follows on from the refactor PRs which I've already merged (#3552, #3567).
Quite a big one, but here's the summary:
.fix_string()
. All part of the newlinted_file_test.py
.SourceFix
dataclass and methods on segments to both add them (via.edit()
) and also to retrieve them.Big PR, and a few places that could use some review.