feat: Optional numerics for postgres arrays #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmcruickshank
requested changes
Oct 2, 2022
Comment on lines
+33
to
+35
| ("ArrayAccessorSegment", "[2:10]"), | ||
| ("ArrayAccessorSegment", "[:10]"), | ||
| ("ArrayAccessorSegment", "[2:]"), |
There was a problem hiding this comment.
Can you add a test here for the simple case of [2], which I worry wouldn't pass given your current implementation?
There was a problem hiding this comment.
Sure thing, I have just added the relevant change, thanks for noticing.
- Handle either single int, both numbers, or either numbers when accessing postgres array +ref: #3842
alanmcruickshank
approved these changes
Oct 3, 2022
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #3903 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 185 185
Lines 14288 14288
=========================================
Hits 14288 14288
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the ArrayAccessorSegment to parse empty sides of an array.
i.e. [:2] or [2:]
fixes #3842
+ref: #3842
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.