MySQL: Support REPLACE statement #3964
Conversation
Also fixes usage of SelectPartitionClauseSegment in LoadDataSegment
| Sequence("PARTITION", Ref("SelectPartitionClauseSegment"), optional=True), | ||
| Ref("SelectPartitionClauseSegment", optional=True), |
There was a problem hiding this comment.
Can you explain this one? Docs seem to suggest it has the word PARTITION: https://dev.mysql.com/doc/refman/8.0/en/load-data.html
There was a problem hiding this comment.
SelectPartitionClauseSegment is introduced in e85fcbb (CommitDate: Jul 2 2021) and contains the word "PARTITION" inside.
LoadDataSegment is introduced in e81993f (CommitDate: Jun 29 2022) and misuse SelectPartitionClauseSegment (The misuse was overlooked because test was not included).
I noticed that in the process of implementing ReplaceSegment, fixed it, and add a test to load_data.sql.
There was a problem hiding this comment.
Cool, it makes sense now, thank you!
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #3964 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 188 188
Lines 14423 14426 +3
=========================================
+ Hits 14423 14426 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Also fixes usage of SelectPartitionClauseSegment in LoadDataSegment
Brief summary of the change made
fixes #3947
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.