-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement diff_quality_plugin using command-line rather than Python #4148
Implement diff_quality_plugin using command-line rather than Python #4148
Conversation
https://github.com/barrywhart/sqlfluff into bhart-issue_4094_diff_quality_plugin_use_command_line
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4148 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 195 195
Lines 14920 14939 +19
=========================================
+ Hits 14920 14939 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I know much about this, but code change looks fine from a brief look.
https://github.com/barrywhart/sqlfluff into bhart-issue_4094_diff_quality_plugin_use_command_line
Brief summary of the change made
Fixes #4094, #4142, #4152
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.