Proof-of-concept for clean LuaJIT build #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can confirm that, with this patch, lpeglabel builds with no errors or warnings under LuaJIT. This also restores the static library target, I don't know whether that was removed from lpeg or within lpeglabel but it happens to be the target I need. This isn't careful, or intended for merge, it merely provides the missing macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: commit
988b733849c4050cbe7dea110d86c7c8eec6bf77introduces the use of theLUAI_FUNCmacro, which LuaJIT doesn't have. This is a minimal/sloppy patch which adds the missing macro.I can confirm that, with this patch, lpeglabel builds with no
errors or warnings under LuaJIT.
This also restores the static library target, I don't know whether
that was removed from lpeg or within lpeglabel but it happens to
be the target I need.
This isn't careful, or intended for merge, it merely provides the
missing macro.