Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[osx] Replace the QR Generator with one that works better on a Mac #118

Closed
josegomez opened this issue Apr 16, 2020 · 3 comments · Fixed by #119
Closed

[osx] Replace the QR Generator with one that works better on a Mac #118

josegomez opened this issue Apr 16, 2020 · 3 comments · Fixed by #119
Labels
bug Something isn't working

Comments

@josegomez
Copy link
Collaborator

In OSX the QR Code does't generate properly (on the UI)
image

Need to address/fix
@josegomez josegomez added the bug Something isn't working label Apr 16, 2020
@josegomez
Copy link
Collaborator Author

See #110

@josegomez
Copy link
Collaborator Author

This is a known issue with our QRCode library see: codebude/QRCoder#210

@josegomez
Copy link
Collaborator Author

Removing the Icon fixes the issue, though the icon is "cute" it isn't all that useful. Removing the icon PR coming
image

josegomez added a commit that referenced this issue Apr 16, 2020
@josegomez
Fixes issue #118
5780bf3
@josegomez josegomez linked a pull request Apr 16, 2020 that will close this issue
Fixes issue #118 #119
Merged
josegomez added a commit that referenced this issue Apr 16, 2020
@josegomez
Merge pull request #119 from sqrldev/FixQROnMac
dfd48a8 
Fixes issue #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issue #118 sqrldev/SQRLDotNetClient
1 participant
@josegomez