Version management #115
Merged
Version management #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegomez
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101.
Description:
This updates the
GitHubHelperclass to handle the agreed upon version management scheme. The client now looks at it's own assembly version number when checking for updates instead of reading the version file. I left the writing of the version file in the installer though for backwards compatibility, we can remove this once we're down a few versions with both the installer and the client.Notes:
This also adds a more convenient way for authenticating to Github for development. Just place a file called
GithubAuthToken.txtcontaining a Github personal access token in the format oftoken 5c19b5ada557335de35ed54642c363f82ac1da18in the root directory of the installer project. It will then be copied to the output directory during build and is used by the installer if present. I also added this file to the.gitignorefile, so it should never get uploaded to Github.