Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Correctly install OSX .pkg format #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hickey
Copy link
Contributor

@hickey hickey commented Aug 3, 2021

This is the change that allows OSX to install crc starting with version 1.27.1.

This change will contain conflicts once GH-3 has been accepted and merged. Once GH-3 has been merged, I will rebase against current master and resolve the conflicts. The only real change will be that the echo line that displays the size of the download file needs to be moved into each path of the if statement. In my testing I used the following:

file_size=$(curl -sI $download | grep "Content-Length:" | sed 's/Content-Length: //g' | tr -d '[:space:]')
echo "This is a large file to download: $(format_num ${file_size})"

Closes #2

if [[ "$os" == "macos" && $(semver_compare $install_version 1.26.0) == 1 ]]; then
download="https://mirror.openshift.com/pub/openshift-v4/clients/crc/${install_version}/crc-${os}-amd64.pkg"
curl -L# -N -o crc-download.pkg "${download}"
installer -pkg crc-download.pkg -target ${install_path}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My testing is still on going (as pulling 3.26GB is not exactly fast), so there might be one or two minor changes to the installer line. Hopefully that will be resolved before any action is to be taken on this PR.

@sqtran sqtran changed the title Correctly install OSX .pkg format WIP: Correctly install OSX .pkg format Aug 3, 2021
@hickey
Copy link
Contributor Author

hickey commented Aug 3, 2021

I am going to rebase and bring in the changes from master, but there are a few issues with the installer. So it is going to be a bit more time to work out how to make installer properly install the binaries in $install_path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install of crc on OSX results in URL not found
1 participant