Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds aurl tag #131

Closed
wants to merge 1 commit into from
Closed

Adds aurl tag #131

wants to merge 1 commit into from

Conversation

scuml
Copy link
Contributor

@scuml scuml commented Sep 17, 2022

Updates the README and adds an aurl convenience snippet - which outputs:
<a href="{% url '{$0}' %}">$1</a>

@squ1b3r
Copy link
Owner

squ1b3r commented Sep 19, 2022

@scuml Thanks for all your contributions!

@squ1b3r squ1b3r closed this Sep 19, 2022
@squ1b3r
Copy link
Owner

squ1b3r commented Sep 19, 2022

@scuml Since you already initiated work related to fields would you mind adding model fields that are still missing? From just a quick overview I'd say we are at least missing PositiveBigIntegerField and JSONField

@scuml
Copy link
Contributor Author

scuml commented Sep 19, 2022

All missing fields, including PositiveBigIntegerField and JSONField, have already been merged in with #129
https://github.com/squ1b3r/Djaneiro/pull/129/files

@scuml
Copy link
Contributor Author

scuml commented Sep 19, 2022

Could you merge this in? Looks like it was just closed without being merged.

@squ1b3r
Copy link
Owner

squ1b3r commented Sep 19, 2022

Ah, right, but we are still missing them in the Readme.

@scuml
Copy link
Contributor Author

scuml commented Sep 19, 2022

That's what this branch was for :)

@scuml
Copy link
Contributor Author

scuml commented Sep 19, 2022

(There's a README update included with this)

@squ1b3r
Copy link
Owner

squ1b3r commented Sep 19, 2022

I don't see PositiveBigIntegerField and JSONField in there though. And now when it's merged the README in main still doesn't have those.

@scuml
Copy link
Contributor Author

scuml commented Sep 19, 2022

Oh I see - missing in the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants