Validate elements are structs #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
force-pushed
the
kve/validate-elements-are-structs
branch
from
7d61d6f
to
17af259
Compare
bencochran
approved these changes
Dec 18, 2020
kylebshr
approved these changes
Dec 18, 2020
|
Ok @bencochran saves the day once again; this is now compile time |
kyleve
force-pushed
the
kve/validate-elements-are-structs
branch
from
3c06cd9
to
9a96182
Compare
watt
reviewed
Dec 19, 2020
watt
approved these changes
Dec 19, 2020
kyleve
force-pushed
the
kve/validate-elements-are-structs
branch
2 times, most recently
from
c4e98f0
to
aeeb1e5
Compare
kyleve
added a commit
that referenced
this pull request
Jan 12, 2021
* origin/main: Bump redcarpet from 3.5.0 to 3.5.1 Prep 0.19.1 Update CHANGELOG Revert "Merge pull request #190 from square/kve/validate-elements-are-structs" Prep 0.19.0 Remove Travis builds Set up Github Actions Add a test for how often the builder is called Code review, add a couple methods that I used in validating the behaviour of negative positions Validate elements are structs Fix empty environment referencing a forever-living MeasurementCache. Fix SPM build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces validations to ensure that elements are structs – since things will break in weird ways if this is not true unless you are very very careful.