Allow specifying which axes are included in the final measurement when using ElementContent(measuring:) #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n using ElementContent(measuring:)
kyleve
commented
Dec 9, 2023
| @@ -279,8 +279,23 @@ extension ElementContent { | |||
| /// | |||
| /// This is useful if you are placing the element in a nested `BlueprintView`, for example (eg | |||
| /// to create a stateful element) and just need this element to be correctly sized. | |||
| public init(measuring element: Element) { | |||
| storage = MeasureElementStorage(child: element) | |||
There was a problem hiding this comment.
Posting here for posterity: We could expose a method like
extension Element {
func asSpacer(along axes: MeasuringAxes = .both) -> Element { ... }
}So that you could use any ol' element as a dynamic spacer – which has been an infrequent but not uncommon or unreasonable ask. I think for now, I'm not going to add this, but this would make it easier for some of these cases. I might put a call out in #market-ios to see if anyone would find this helpful.
|
@watt pointed out I can wrap this up in another element and then just ignore one of the measurements, which makes a lot more sense! I entirely missed that last week when I had been trying to figure out how to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ElementContent(measuring:)to create essentially a smart "Spacer" based on the size of an element, it's desirable to include in the final size on only one of the measurement dimensions. Thus, expose anAxestype you can optionally pass to the initializer to control this.