Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnest Box.CornerStyle #508

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Unnest Box.CornerStyle #508

merged 4 commits into from
Aug 14, 2024

Conversation

g-mark
Copy link
Contributor

@g-mark g-mark commented Aug 7, 2024 •
edited
Loading

Since Box.CornerStyle is used for other things besides specifying the corners of a Box, this PR moves the CornerStyle type to the root of the framework.

To maintain compatibility, a typealias is added to Box, so consumers can continue to use Box.CornerRadius.

kyleve
kyleve reviewed Aug 7, 2024
View reviewed changes
CornerStyle.swift Outdated Show resolved Hide resolved
@g-mark g-mark marked this pull request as ready for review August 8, 2024 11:45
@g-mark g-mark requested a review from a team as a code owner August 8, 2024 11:45
@g-mark g-mark merged commit 73ba67c into main Aug 14, 2024
5 checks passed
@g-mark g-mark deleted the sgrosmark/fix/unnest-cornerstyle branch August 14, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleve kyleve kyleve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-mark @kyleve