Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Commit

Permalink
Fix Assisted Factory binding location.
Browse files Browse the repository at this point in the history
The source location for assisted factory bindings was being set at the `file`, `line`, and `function` within the `AssistedInjectionArities.swift` file, which makes the debug information incorrect for errors such as `MissingProvider`. This change should correctly place the source location info at the site of the binding for assisted factories.
  • Loading branch information
sebastianv1 committed Aug 31, 2020
1 parent e9794be commit e987d25
Show file tree
Hide file tree
Showing 5 changed files with 340 additions and 70 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

#### Bug Fixes

* Fix Assisted Injection `SourceLocation` info.
[Sebastian Shanus](https://github.com/sebastianv1)
[#166](https://github.com/square/Cleanse/pull/166)

* Fix `WeakProviders` becoming deinitialized.
[Sebastian Shanus](https://github.com/sebastianv1)
[#98](https://github.com/square/Cleanse/issues/98)
Expand Down
5 changes: 4 additions & 1 deletion Cleanse/AssistedInjection.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ extension AssistedInjectionBuilder {
return factory(
Assisted<Tag.Seed> { seed }
)
})
},
file: file,
line: line,
function: function)
return BindingReceipt()
}
}
Loading

0 comments on commit e987d25

Please sign in to comment.