Paged list layouts now support using bounds, instead of itemInsets #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
force-pushed
the
kve/respect-layout-bounds
branch
from
fc7020c
to
d17ebc0
Compare
robmaceachern
approved these changes
Jun 14, 2023
| defaultWidth: bounds.width.clamp(pageSize.width) | ||
| ) | ||
|
|
||
| var lastMaxY : CGFloat = 0 |
There was a problem hiding this comment.
Looks like this was pre-existing but the name lastMaxY is a bit confusing for the horizontal direction.
There was a problem hiding this comment.
I use width/height and x/y throughout these layouts, and then flip them based on direction; since I found it clearer than "axis/cross axis", which is what blueprint uses.
kyleve
force-pushed
the
kve/respect-layout-bounds
branch
from
47c2327
to
e32cf29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Paged List Layouts to respect and use the
boundsproperty, which will allow us to properly apply market screen widths in Market. I've removeditemInsets, sincebounds.paddingdoes this instead.Checklist
Please do the following before merging:
Mainsection.