CONV-1435: Gravity layout #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nononoah
approved these changes
Jul 27, 2023
kyleve
reviewed
Jul 28, 2023
| let targetY = self.contentOffset.y + heightDelta | ||
|
|
||
| self.contentOffset.y = min(targetY, maxContentOffsetY) | ||
| } |
There was a problem hiding this comment.
Can we add an assert if .bottom is provided, but the layout direction is .horizontal? Just so folks know it's not supported.
kyleve
approved these changes
Jul 28, 2023
gilgtm
force-pushed
the
gil/custom-keyboard-adjustment-mode
branch
from
f11883f
to
94ac6f9
Compare
gilgtm
force-pushed
the
gil/gravity
branch
2 times, most recently
from
0643576
to
b4a0e45
Compare
- Adds a new Chat App demo and a new behavior called verticalLayoutGravity. When verticalLayoutGravity is set to bottom, scrolling works the way you would expect for a messaging app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gravity-demo.mp4
Checklist
Please do the following before merging:
Mainsection.