Fix SPOS reordering crash / header reuse issue + prep 14.0.3 #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent types of headers. The wrong ObjectIdentifier was being compared and stored.
kyleve
commented
Mar 3, 2024
There was a problem hiding this comment.
Actual fix is in here
There was a problem hiding this comment.
(Note: I'm gonna follow up with an automated test for this, but want to get this landed before branch cut.)
kyleve
changed the title
kyleve
changed the title
kyleve
commented
Mar 3, 2024
| [Main]: https://github.com/square/Listable/compare/13.1.0...main | ||
| [Main]: https://github.com/square/Listable/compare/14.0.3...main | ||
| [14.0.3]: https://github.com/square/Listable/square/14.0.2...14.0.3 | ||
| [14.0.2]: https://github.com/square/Listable/square/14.0.1...14.0.2 |
There was a problem hiding this comment.
These weren't added in the prior releases
robmaceachern
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://block.atlassian.net/browse/UI-5594
Fix a crash that could occur during cell reuse if a list contained different types of headers. The wrong
ObjectIdentifierwas being compared and stored. I'm surprised this ever worked – but it seems like some timing changed (maybe when we dropped iOS 14?) that this wasn't hit nearly as frequently – it's now pathological for any list with different header types.Checklist
Please do the following before merging:
Mainsection.