Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:compiler-k2-utils and complementary testing apis #1116

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

RBusarow
Copy link
Collaborator

No description provided.

@RBusarow RBusarow marked this pull request as ready for review February 19, 2025 03:39
@RBusarow RBusarow enabled auto-merge (rebase) February 20, 2025 01:15
public fun ClassId.child(nameString: String): ClassId = nested(nameString)

/**
* alias for [com.squareup.anvil.compiler.testing.nested]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this may be copy pasta / could use an update

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... I'll get this at some point soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something that we need to decide now but I'm wondering if we want to treat this module similarly to the existing compiler-utils module where it's expressly not a stable API but still made available for consumers' convenience

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my thinking as well.

@RBusarow RBusarow merged commit 51428a2 into main-k2 Feb 20, 2025
17 checks passed
@RBusarow RBusarow deleted the rick/testing-utils branch February 20, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants