Add the kotlinx binary compatibility plugin #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelWilcox
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Debating whether we will want to disable it for this module since we don't guarantee API compatibility on this and more-so provide it for convenience, but makes sense to start enabled and see whether we end up with noise problems.
There was a problem hiding this comment.
Those were pretty much my thoughts as well. My rationale for leaving it enabled is that even though we don't guarantee anything, it's still nice to know? Unless it gets annoying.
There was a problem hiding this comment.
Yup I agree completely! And it's easy remove later if it does get annoying
RBusarow
force-pushed
the
rick/binary-compatibility
branch
from
8dcf24a to
2cf82e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Kotlin/binary-compatibility-validator