Add support for ECC to the pkix package #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmontgomery-square
approved these changes
Dec 1, 2021
mbyczkowski
approved these changes
Dec 1, 2021
| } | ||
| signer = priv | ||
| case encryptedPKCS8PrivateKeyPEMBLockType: | ||
| b, err := pemutil.DecryptPKCS8PrivateKey(pemBlock.Bytes, password) |
There was a problem hiding this comment.
is this something we need this 3p library for? (so nothing in stdlib or x/crypto that we can use?)
There was a problem hiding this comment.
Unfortunately not, see this discussion: golang/go#8860 (comment)
That thread is where I found this package, which looks like it may get considered for inclusion into x/crypto.
jdtw
added a commit
that referenced
this pull request
Dec 2, 2021
* master: Add support for ECC to the pkix package (#130)
mbyczkowski
pushed a commit
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating, importing, and exporting ECDSA/Ed25519 keys to the
pkixpackage. Commandline options will be added to certstrap to expose this functionality in a followup PR[1].Since the standard library doesn't support encrypted PKCS8[2], we take a dependency on the pemutil[3] package to do this encryption/decryption for us.
All RSA operations continue to use PKCS1 for backwards compatibility.
[1] WIP at #128
[2] golang/go#8860 (comment)
[3] https://pkg.go.dev/go.step.sm/crypto/pemutil