Add ability to create intermediate CA cert #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| return nil, err | ||
| } | ||
|
|
||
| authTemplate.Subject = rawCsr.Subject |
There was a problem hiding this comment.
This should probably be RawSubject
csstaub
force-pushed
the
cs/intermediate-ca
branch
from
d1f5850
to
308aeab
Compare
| proposedExpiry := time.Now().AddDate(years, 0, 0).UTC() | ||
| // ensure cert doesn't expire after issuer | ||
| if caExpiry.Before(proposedExpiry) { | ||
| authTemplate.NotAfter = caExpiry |
There was a problem hiding this comment.
we should show a warning when we take this branch.
There was a problem hiding this comment.
yeah. probably ditto for host certs.
|
lgtm for reals this time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r: @alokmenghrajani