-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding URI SAN support #63
Adding URI SAN support #63
Conversation
This PR depends on Go 1.11 |
I tested a bit, and it seems like the CSRs work, but we'll need to add support to also, it's pretty weird to put a URI in the Common Name. I think that likely isn't what anyone will intend. Maybe we should make -common-name required if no --domain flag is passed too |
How about IPs? We could just remove URIs (and IPs?) from the naming switch statement in |
README.md
Outdated
@@ -66,9 +66,9 @@ Created out/Alice.key | |||
Created out/Alice.csr | |||
``` | |||
|
|||
certstrap requires at least one of `-common-name`, `-ip`, or `-domain` flags to be set in order to generate a certificate signing request. The CN for the certificate will be found from these fields. | |||
certstrap requires at least one of `-common-name`, `-ip`, `-domain`, or `-uri` flags to be set in order to generate a certificate signing request. The CN for the certificate will be found from these fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line isn't quite accurate. We require at least one of -common-name or -domain now
One minor nit in the README.md, otherwise looks good now |
No description provided.