Create new x509 templates #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csstaub
approved these changes
May 29, 2019
|
I agree this is a nicer way to handle it. Thanks for the contribution @julianedwards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was doing some testing on a package I wrote that uses certstrap and noticed that when I use certain pkix package functions (CreateCertificateAuthority, CreateCertificateSigningRequest, etc.) data is persisted due to the use of a global variable as the certificate template. As far as I can tell, there is no need to presist data once a certificate is created and it causes a bug when I want to create a new certificate (if I omit a field that was previously filled in, the field from the last certificate will not get overwritten and persists with the new certificate).
Hope this change is helpful!
Julian