Add option to create CA restricted to some domains #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fd0
force-pushed
the
add-permitted-domain
branch
from
61e08b0
to
99059f9
Compare
|
Thank you. This looks fine in principle. I'm about to travel, but I will review the code shortly. |
mcpherrinm
approved these changes
Apr 7, 2020
|
Sorry, not sure why I approved but didn't merge this earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #92 this PR adds the option to create a CA restricted to subdomains of some domains. Sample usage:
This is a first version, please let me know what you think! Ideas for future improvement: We could print an error if a certificate is to be signed which is not valid with the restrictions.
IP network restrictions work in a very similar way.
Closes #92