Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileSpec.builder convenience for MemberName #1585

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Add FileSpec.builder convenience for MemberName #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions kotlinpoet/api/kotlinpoet.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ public abstract interface annotation class com/squareup/kotlinpoet/ExperimentalK
public final class com/squareup/kotlinpoet/FileSpec : com/squareup/kotlinpoet/Annotatable, com/squareup/kotlinpoet/Taggable {
public static final field Companion Lcom/squareup/kotlinpoet/FileSpec$Companion;
public static final fun builder (Lcom/squareup/kotlinpoet/ClassName;)Lcom/squareup/kotlinpoet/FileSpec$Builder;
public static final fun builder (Lcom/squareup/kotlinpoet/MemberName;)Lcom/squareup/kotlinpoet/FileSpec$Builder;
public static final fun builder (Ljava/lang/String;Ljava/lang/String;)Lcom/squareup/kotlinpoet/FileSpec$Builder;
public fun equals (Ljava/lang/Object;)Z
public static final fun get (Ljava/lang/String;Lcom/squareup/kotlinpoet/TypeSpec;)Lcom/squareup/kotlinpoet/FileSpec;
Expand Down Expand Up @@ -275,6 +276,7 @@ public final class com/squareup/kotlinpoet/FileSpec$Builder : com/squareup/kotli

public final class com/squareup/kotlinpoet/FileSpec$Companion {
public final fun builder (Lcom/squareup/kotlinpoet/ClassName;)Lcom/squareup/kotlinpoet/FileSpec$Builder;
public final fun builder (Lcom/squareup/kotlinpoet/MemberName;)Lcom/squareup/kotlinpoet/FileSpec$Builder;
public final fun builder (Ljava/lang/String;Ljava/lang/String;)Lcom/squareup/kotlinpoet/FileSpec$Builder;
public final fun get (Ljava/lang/String;Lcom/squareup/kotlinpoet/TypeSpec;)Lcom/squareup/kotlinpoet/FileSpec;
public final fun scriptBuilder (Ljava/lang/String;Ljava/lang/String;)Lcom/squareup/kotlinpoet/FileSpec$Builder;
Expand Down
4 changes: 4 additions & 0 deletions kotlinpoet/src/main/java/com/squareup/kotlinpoet/FileSpec.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,10 @@ public class FileSpec private constructor(
return builder(className.packageName, className.simpleName)
}

@JvmStatic public fun builder(memberName: MemberName): Builder {
return builder(memberName.packageName, memberName.simpleName)
}

@JvmStatic public fun builder(packageName: String, fileName: String): Builder =
Builder(packageName, fileName, isScript = false)

Expand Down
7 changes: 7 additions & 0 deletions kotlinpoet/src/test/java/com/squareup/kotlinpoet/FileSpecTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,4 +1204,11 @@ class FileSpecTest {
FileSpec.builder(className)
}
}

@Test fun memberNameFactory() {
val memberName = MemberName("com.example", "Example")
val spec = FileSpec.builder(memberName).build()
assertThat(spec.packageName).isEqualTo(memberName.packageName)
assertThat(spec.name).isEqualTo(memberName.simpleName)
}
}