Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nullability of lambdas in KSTypeReference.toTypeName #1756

Merged
merged 2 commits into from
Dec 2, 2023
Merged

fix nullability of lambdas in KSTypeReference.toTypeName #1756

merged 2 commits into from
Dec 2, 2023

Conversation

gabrielittner
Copy link
Contributor

With the change of how lambdas are converted to TypeName in 1.15.2 the nullability of the converted reference is lost. This fixes it and makes the behavior match the else case (KSType.toTypeName) which also preserves nullability.

Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@ZacSweers ZacSweers merged commit 51b218b into square:main Dec 2, 2023
4 checks passed
@Egorand
Copy link
Collaborator

Egorand commented Dec 4, 2023

Awesome, will release today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants