Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Aliased imports with nested class #1876

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: Aliased imports with nested class #1876

merged 1 commit into from
Apr 2, 2024

Conversation

psymoon
Copy link
Collaborator

@psymoon psymoon commented Apr 1, 2024

Closes #1838

  • docs/changelog.md has been updated if applicable.
  • CLA signed.

@psymoon psymoon force-pushed the schae.2024-04-01.alias-import branch from 374a85c to 6731fea Compare April 1, 2024 18:59
@psymoon psymoon force-pushed the schae.2024-04-01.alias-import branch from 6731fea to 042175f Compare April 1, 2024 19:04
JakeWharton
JakeWharton approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing tests pass. New tests look fine. Ship it.

@psymoon psymoon merged commit 84ed461 into main Apr 2, 2024
8 checks passed
@psymoon psymoon deleted the schae.2024-04-01.alias-import branch April 2, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

@Egorand Egorand Awaiting requested review from Egorand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aliased imports not working for nested classes and generate unused imports and usage of FQNs
2 participants
@psymoon @JakeWharton