Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mirror and element APIs #919

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

ZacSweers
Copy link
Collaborator

This deprecates existing mirror and element APIs, as they don't (and can't) return completely correct information about Kotlin types. This is just a first pass to soft-deprecate them and communicate that metadata should be used instead.

One thing not covered - CodeBlock accepts TypeMirror and Element as possible arguments. We could remove them, but it would be a behavior change. Thoughts?

This deprecates existing mirror and element APIs, as they don't (and can't) return completely correct information about Kotlin types. This is just a first pass to soft-deprecate them and communicate that metadata should be used instead.

One thing not covered - `CodeBlock` accepts `TypeMirror` and `Element` as possible arguments. We could remove them, but it would be a behavior change. Thoughts?
@ZacSweers ZacSweers requested a review from Egorand May 24, 2020 23:23
@ZacSweers
Copy link
Collaborator Author

This also doesn't cover reflective APIs. I think we might be able to make those work since we're using kotlin-reflect anyway

@Egorand
Copy link
Collaborator

Egorand commented May 25, 2020

We can log a warning if someone uses TypeMirror or Element as args to CodeBlock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants