com.squareup.leakcanary.internal.DisplayLeakActivity has leaked

[evant]

* com.squareup.leakcanary.internal.DisplayLeakActivity has leaked:
* GC ROOT static com.android.internal.os.ZygoteInit.mResources
* references android.content.res.Resources.mContext
* references android.app.ContextImpl.mOuterContext
* leaks com.squareup.leakcanary.internal.DisplayLeakActivity instance
* Reference Key: bd8db00d-ce02-4f73-97fe-4bd36c65502f
* Device: samsung samsung GT-I9500 ja3gub
* Android Version: 4.4.2 API: 19
* Durations: watch=5015ms, gc=145ms, heap dump=543ms, analysis=13738ms

[evant]

Also,

* com.willowtreeapps.leakleak.MainActivity has leaked:
* GC ROOT static android.view.ViewConfiguration.sConfigurations
* references android.util.SparseArray.mValues
* references array java.lang.Object[].[0]
* references android.view.ViewConfiguration.mContext
* leaks com.willowtreeapps.leakleak.MainActivity instance
* Reference Key: 238d140a-1864-4d7b-9734-605df0da7693
* Device: samsung samsung GT-I9500 ja3gub
* Android Version: 4.4.2 API: 19
* Durations: watch=5035ms, gc=138ms, heap dump=584ms, analysis=9665ms

Could reproduce both in a project with just a blank activity on that device (galaxy s4)

hprof: https://drive.google.com/file/d/0B1aqwLiIm64cb0VONzhwb2VCN3M/view?usp=sharing

[pyricau]

The first one is really wrong. The global app wide resource instance has been built with a context that's the activity instead of the application instance.

Resources doesn't have a mContext field so this leak might not exist in the latest versions of AOSP. I also can't find a version that has it.

I think we could add an excluded ref for android.content.res.Resources.mContext in Samsung / API 19. If you want to fix this leak for your app, you could access ZygoteInit.mResources using a reflection and replace the instance with the one from getApplicationContext().getResources() (if that one isn't stupidly holding to the activity as well), OR you could (via reflection again) maybe change the context in Resources.mContext.

Same goes for the second one. I can't find android.view.ViewConfiguration.mContext. I suspect Samsung is playing a dirty game of changing the sources here. I would ignore this one too.

[xckevin]

I got this, based on com.squareup.leakcanary:leakcanary-android:1.3

* com.squareup.leakcanary.internal.DisplayLeakActivity has leaked:
* GC ROOT static android.view.inputmethod.InputMethodManager.mInstance
* references android.view.inputmethod.InputMethodManager.mCurRootView
* references com.android.internal.policy.impl.PhoneWindow$DecorView.mContext
* leaks com.squareup.leakcanary.internal.DisplayLeakActivity instance
* Reference Key: 891001d9-2b87-458c-a6f2-66c20ba0625d
* Device: samsung samsung GT-I9308 m0zm
* Android Version: 4.0.4 API: 15
* Durations: watch=5014ms, gc=225ms, heap dump=1449ms, analysis=55747ms

[MatFl]

I'm also getting the android.view.ViewConfiguration.mContext leak in a activity of my app. The device is a 2012 Nexus 7 (with an older cyanogenmod version (4.3.1)). Could you also make an exclude for this?

It should be noted, that this leak only occurs in a activity which is opened from the launcher.