EditText Blink causes memory leak in AlertDialog and DialogFragment

[Yky]

See AOSP issue 188551: https://code.google.com/p/android/issues/detail?id=188551

Can be avoided by calling setCursorVisible(false) in the dismiss() method of the Dialog.

[Yky]

Added pull request for ignore of this AOSP bug.

[hidroh]

@Yky you mean setCursorVisible(false)?

[Yky]

@hidroh Yes, I corrected my comment above.

[Yky]

This leak is now confirmed by Google and has been fixed in Marshmallow.

[pyricau]

PR mentioned above: #298

[Yky]

@pyricau I think this can be closed as the commit is included in 1.4-beta2

[jrodbx]

@Yky thanks!

[knezmilos13]

I am using 1.4-beta2, on 4.1.1 it says: "This can be fixed manually by calling setCursorEnabled(false) ..." while it should say setCursorVisible(false), right?

[pyricau]

Thx @knezmilos13 , fixed.

[realdadfish]

Sorry for reviving this from the death, but I figured that the exact same leak occurs also on a Samsung Device with 5.0.1 installed, but without the need of having a DialogFragment present. A simple EditText with a blinking cursor was enough to trigger it for me.

I tried the solution and called setCursorVisible(false) in onDetachFromWindow() from the surrounding compound view, but this did not help. Guess we just have to wait until 5.x finally dies.

[Yky]

@realdeadfish I would try moving the setCursorVisible(false) to a different lifecycle method that is always called before your Activity is destroyed. I don't know the details of your leak but you could try onPause().

[yoavgray]

I'm seeing this as well on a Samsung S7 with Android 7 running on it. LeakCanary says that a Thread is referencing InputConnectionWrapper.mTarget about ~15 times, and then it leaks a Dialogfragment with the EditText

[madim]

@realdeadfish Did you fix that?

[indiandragon]

Guys, the only solution that worked for me was to Override InputConnection to return null as suggested by @aslakjo in SO - https://stackoverflow.com/a/18697200

I cannot believe this issue is still not addressed in android.

[adsonafonso]

I'm using a Pixel 2, Android 10 and I ran into this

├─ android.net.ConnectivityThread
│ Leaking: UNKNOWN
│ Thread name: 'ConnectivityThread'
│ GC Root: Java local variable
│ ↓ thread ConnectivityThread.
│ ~~~~~~~~~~~~
├─ android.os.Message
│ Leaking: UNKNOWN
│ ↓ Message.obj
│ ~~~
╰→ co.optimal.android.util.ChoosePhotoFragment
​ Leaking: YES (Fragment#mFragmentManager is null and ObjectWatcher was watching this)
​ key = 745f218b-4145-409b-99e7-f84ef01d1bc2
​ watchDurationMillis = 39206
​ retainedDurationMillis = 34205
, retainedHeapByteSize=504845, pattern=instance field android.os.Message#obj...