Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let leakcanary-android-no-op minSDK = 8 to support more device. #57

Closed
liaohuqiu opened this issue May 12, 2015 · 1 comment
Closed

Let leakcanary-android-no-op minSDK = 8 to support more device. #57

liaohuqiu opened this issue May 12, 2015 · 1 comment

Comments

@liaohuqiu
Copy link
Contributor

A lot of APPs still support API Level 8. I think I would be better to support API Level 8 in leakcanary-android-no-op.
@snowdream
Copy link

I have got the same error.

D:\workspace\snowdream\git\android-core\app\src\main\AndroidManifest.xml:23:5 Error:
        uses-sdk:minSdkVersion 8 cannot be smaller than version 9 declared in library D:\workspace\snowdream\git\android-core\app\build\intermediates\exploded-aar\com.squareup.leakcanary\leakcanary-android-no-op\1.3\AndroidManifest.xml
        Suggestion: use tools:overrideLibrary="com.squareup.leakcanary.android.noop" to force usage
:app:processDebugManifest FAILED

pyricau added a commit that referenced this issue May 12, 2015
@pyricau
Merge pull request #68 from liaohuqiu/master
d16aa4d 
down minSDK to 8, fix #57
Yky pushed a commit to Yky/leakcanary that referenced this issue Feb 21, 2016
@liaohuqiu
down minSDK to 8, fix square#57
88b434c
Yky pushed a commit to Yky/leakcanary that referenced this issue Feb 21, 2016
@pyricau
Merge pull request square#68 from liaohuqiu/master
bac5a70 
down minSDK to 8, fix square#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snowdream @liaohuqiu