Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect DisplayLeakActivity.setTheme() from receiving an incompatible theme #237

Merged
merged 3 commits into from
Sep 2, 2015

Conversation

ErikHellman
Copy link

No description provided.

@pyricau
Copy link
Member

pyricau commented Aug 10, 2015

Can you add a comment to detail what's up, and also change to this:

  public void setTheme(int resId) {
    // insert here some comment explaining why we're doing this.
    if (resId != R.style.leak_canary_LeakCanary_Base) {
      return;
    }
    super.setTheme(resid);
  }

@pyricau
Copy link
Member

pyricau commented Aug 28, 2015

I can't merge without you signing the CLA first :) https://github.com/square/leakcanary/blob/master/CONTRIBUTING.md

Also, it's a nit but it'd be nice to change this to return early, as I was showing above. Otherwise I'll just do a follow up commit, that's fine too.

@ErikHellman
Copy link
Author

Signed CLA and made it return early. :)

pyricau added a commit that referenced this pull request Sep 2, 2015
Protect DisplayLeakActivity.setTheme() from receiving an incompatible theme
@pyricau pyricau merged commit 0be6fe9 into square:master Sep 2, 2015
@pyricau pyricau added this to the 1.4 milestone Jan 8, 2016
Yky pushed a commit to Yky/leakcanary that referenced this pull request Feb 21, 2016
Protect DisplayLeakActivity.setTheme() from receiving an incompatible theme
Pengchengxiang pushed a commit to XLibrarys/leakcanary that referenced this pull request Jan 2, 2017
Protect DisplayLeakActivity.setTheme() from receiving an incompatible theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants