2.0.0-beta3 release #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamerbader
reviewed
Aug 27, 2024
| COMMIT_SHA = '6432c60c8568' | ||
| VERSION = '2.0.0-beta3' | ||
| COMMIT_SHA = 'd86d59057def' | ||
| CLOUDFRONT_DOMAIN = 'd3eygymyzkbhx3.cloudfront.net' |
There was a problem hiding this comment.
This cloudfront domain is static correct? It won't really change from release to release?
There was a problem hiding this comment.
correct, it only changes based on environments, but neither our scripts or the ones owned by MDX have environment awareness code, so I think it's more clear they're all pointing to one environment (prod)
tamerbader
reviewed
Aug 27, 2024
Comment on lines
+86
to
+93
| # This here is only so we can show some progress, files are heavy | ||
| open(filename, 'w') do |f| | ||
| response.read_body do |chunk| | ||
| f.write chunk | ||
| progress += chunk.length | ||
| printf("\rDownloaded: %.2f%%", 100*(progress/size)) | ||
| end | ||
| end |
There was a problem hiding this comment.
Thanks for adding this! Love being able to see the progress of the download
tamerbader
approved these changes
Aug 27, 2024
plinio-square
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.