Don't replace nullable absent properties with null #1856
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was always supposed to be a feature of moshi but not actually enforced in kotlin reflect or code gen. This fixes that in both with a regression test. Now nullable properties either need to explicitly declare a default value or explicitly have a null present in the JSON.
This uses a couple clever tricks with kotlin contracts to avoid the extra runtime intrinsic checks.
It's worth mentioning that while this was always how this was advertised to work, this is likely going to be a fairly invasive change to people that were implicitly relying on the old behavior.