Crash: Unexpected TLS version: NONE #3719

anthony3444 · 2017-12-12T05:47:45Z

Hi there!

First at all thank you very much for your library!

I've integrated okhttp3 since couple months ago; there were no problem until yesterday with an user (Huawei, model MHA-L29, on Android 7.0):

Fatal Exception: java.lang.IllegalArgumentException: Unexpected TLS version: NONE
       at okhttp3.TlsVersion.forJavaName(TlsVersion.java:53)
       at okhttp3.Handshake.get(Handshake.java:56)
       at okhttp3.internal.connection.RealConnection.connectTls(RealConnection.java:300)
       at okhttp3.internal.connection.RealConnection.establishProtocol(RealConnection.java:268)
       at okhttp3.internal.connection.RealConnection.connect(RealConnection.java:160)
       at okhttp3.internal.connection.StreamAllocation.findConnection(StreamAllocation.java:256)
       at okhttp3.internal.connection.StreamAllocation.findHealthyConnection(StreamAllocation.java:134)
       at okhttp3.internal.connection.StreamAllocation.newStream(StreamAllocation.java:113)
       at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:42)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
       at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:93)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
       at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
       at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:125)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
       at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:200)
       at okhttp3.RealCall$AsyncCall.execute(RealCall.java:147)
       at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:776)

Have you got some ideas about this crash?

Thank you very much guys!

The text was updated successfully, but these errors were encountered:

yschimke · 2017-12-12T06:07:04Z

Does your app change the SSL provider in any way? to GMS services e.g. include ProviderInstaller.installIfNeeded. It could also just be the setup of that phone.

Is it a one-off or consistently reproducible?

I've seen a similar issue in rare timing cases either before or after a network issue, a non-standard SSL provider can return NONE as the string. OkHttp might have to handle this more gracefully.

https://github.com/google/conscrypt/blob/c88f9f55a523f128f0e4dace76a34724bfa1e88c/common/src/main/java/org/conscrypt/SSLNullSession.java#L149-L151

anthony3444 · 2017-12-12T06:29:12Z

Hi!

About your questions:

"Does your app change the SSL provider in any way? to GMS services e.g. include ProviderInstaller.installIfNeeded" : no change
"Is it a one-off or consistently reproducible?" : just only 1 crash until now

Is there a manner to catch this exception in my App to avoid a crash?

asfdfdfd · 2017-12-13T15:35:47Z

I could confirm this issue on multiple devices. You could look in details at Crashlytics http://crashes.to/s/188322d298a

Here is part of my application from stacktrace https://gist.github.com/anonymous/eb4c8d96de290e84c3e5be093060023f

I use GMS ProviderInstaller and custom SSLSocketFactory.

dgadelha · 2017-12-23T00:23:18Z

+1:

yschimke · 2017-12-23T10:35:13Z

n.b. my PR fix will turn these into IOExceptions and handle them cleanly e.g. retry other connection routes. But it won't fix an underlying fatal problem e.g. connecting to specific servers with a custom SSLSocketFactory.

anthony3444 · 2018-01-09T20:24:43Z

@yschimke: this crash stills there :( I've added ProviderInstaller.installIfNeeded into my App + a custom SSLSocketFactory. It's really rare, but today 1 user had this crash (Android 7.0 on Galaxy S7 Edge).

yschimke · 2018-01-10T05:06:28Z

@anthony3444 the fix is in the next release (3.10), until then when they happen you will get a crash from OkHttp.

hidroh · 2018-01-22T15:27:21Z

We're observing the same crash. 100% of crashes happen to users on Google phones running Android 8.1.0, though we can't reproduce on the same device we have.

sergicastellsague · 2018-01-24T08:09:29Z

@yschimke do we have an ETA of this release?

yschimke · 2018-01-24T08:37:45Z

I don't, I think we had planned for a 3.10 earlier than this. cc @swankjesse @JakeWharton

kelset · 2018-01-29T16:02:20Z

Hey guys, same crash - it's quite rare for us too, was just wondering if the issue could be kept open until 3.10 is released.

Are there any extra informations that I could provide that may be needed/helpful?

swankjesse · 2018-02-18T20:37:09Z

I think this is fixed in 3.10.

anna-b · 2018-02-20T12:45:37Z

@swankjesse is 3.10 expected to be released any time soon? thanks!

kelset · 2018-02-20T13:41:52Z

@anna-b if you look at the milestone they seem to be aiming for end Feb. So a bit more than a week.

On the Android platform, when the TLS handshake is interrupted, SSLSession.getProtocol() may return "NONE". square#3719 square#3973

vasiledoe · 2018-07-10T09:11:42Z

same error using 3.10 with Retrofit 2

Fatal Exception: java.lang.IllegalArgumentException: Unexpected TLS version: at okhttp3.TlsVersion.forJavaName(TlsVersion.java:53) at okhttp3.TlsVersion.forJavaNames(TlsVersion.java:59) at okhttp3.ConnectionSpec.tlsVersions(ConnectionSpec.java:113) at okhttp3.ConnectionSpec.toString(ConnectionSpec.java:221) at java.lang.String.valueOf(String.java:2683) at java.lang.StringBuilder.append(StringBuilder.java:129) at java.util.AbstractCollection.toString(AbstractCollection.java:458) at java.util.Collections$UnmodifiableCollection.toString(Collections.java:1108) at java.lang.String.valueOf(String.java:2683) at java.lang.StringBuilder.append(StringBuilder.java:129) at okhttp3.internal.connection.ConnectionSpecSelector.configureSecureSocket(ConnectionSpecSelector.java:70) at okhttp3.internal.connection.RealConnection.connectTls(RealConnection.java:274) at okhttp3.internal.connection.RealConnection.establishProtocol(RealConnection.java:251) at okhttp3.internal.connection.RealConnection.connect(RealConnection.java:151) at okhttp3.internal.connection.StreamAllocation.findConnection(StreamAllocation.java:192) at okhttp3.internal.connection.StreamAllocation.findHealthyConnection(StreamAllocation.java:121) at okhttp3.internal.connection.StreamAllocation.newStream(StreamAllocation.java:100) at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:42) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67) at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:93) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67) at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:120) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67) at com.justdo.logic.network.RestClient$1.intercept(RestClient.java:60) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67) at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:185) at okhttp3.RealCall$AsyncCall.execute(RealCall.java:135) at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607) at java.lang.Thread.run(Thread.java:762)

yschimke · 2018-07-10T09:57:35Z

Mostly fixed in 3.10, but there was a race condition. Hopefully fixed correctly in 3.11

dave-r12 · 2018-07-10T18:57:28Z

Also, that stack trace appears to be 3.8.

TomasYu · 2018-07-18T06:06:34Z

Is this fixed in 3.11?

yschimke · 2018-07-18T06:29:59Z

Yes, if you see it with 3.11 or it manifests in other similar ways, please open an issue.

gongzelong0718 · 2018-07-31T08:22:31Z

@dave-r12 ve
How do you judge that the issue opened by @vasiledoe happened when using okhttp 3.8 or do I misunderstanding something?

gongzelong0718 · 2018-07-31T08:27:01Z

@yschimke

Thanks for your reply.
Could you specify which commit in 3.11 fix that issue?

I just upgrade to 3.10 to fix another crash (#3438)
Could you explain more about under which rare condition does this crash still happen in 3.10 ?

swankjesse · 2018-07-31T10:53:11Z

@gongzelong0718 please give 3.11 a try. The commits in the release are on our git history.

dave-r12 · 2018-08-01T13:10:34Z

@gongzelong0718 the stack trace includes class names and line numbers. We can correlate that information with git tags to understand possible versions. For example: okhttp3.ConnectionSpec.tlsVersions(ConnectionSpec.java:113) at

In version 3.8 it contains this line of code:
https://github.com/square/okhttp/blob/parent-3.8.0/okhttp/src/main/java/okhttp3/ConnectionSpec.java#L113

And in 3.10:
https://github.com/square/okhttp/blob/parent-3.10.0/okhttp/src/main/java/okhttp3/ConnectionSpec.java#L113

Note that 3.10 has no executable code!

chwnFlyPig · 2019-03-26T05:13:27Z

this issue still exists in okhttp3.12.1.
here is my logs:

yschimke mentioned this issue Dec 13, 2017

avoid using invalid sessions #3721

Merged

yschimke added the bug Bug in existing code label Dec 28, 2017

yschimke added this to the 3.10 milestone Dec 30, 2017

yschimke closed this as completed Dec 30, 2017

yschimke reopened this Jan 30, 2018

swankjesse closed this as completed Feb 18, 2018

guoxin-nj added a commit to guoxin-nj/okhttp that referenced this issue Jun 29, 2018

Fix "Unexpected TLS version:NONE"

312164c

On the Android platform, when the TLS handshake is interrupted, SSLSession.getProtocol() may return "NONE". square#3719 square#3973

guoxin-nj mentioned this issue Jun 29, 2018

Fix "Unexpected TLS version:NONE" #4100

Closed

guoxin-nj pushed a commit to guoxin-nj/okhttp that referenced this issue Jun 29, 2018

Fix "Unexpected TLS version:NONE"

1d1d48d

On the Android platform, when the TLS handshake is interrupted, SSLSession.getProtocol() may return "NONE". square#3719 square#3973

guoxin-nj mentioned this issue Jun 29, 2018

Fix "Unexpected TLS version:NONE" #4101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash: Unexpected TLS version: NONE #3719

Crash: Unexpected TLS version: NONE #3719

anthony3444 commented Dec 12, 2017

yschimke commented Dec 12, 2017 •

edited

Loading

anthony3444 commented Dec 12, 2017

asfdfdfd commented Dec 13, 2017 •

edited

Loading

dgadelha commented Dec 23, 2017

yschimke commented Dec 23, 2017

anthony3444 commented Jan 9, 2018

yschimke commented Jan 10, 2018

hidroh commented Jan 22, 2018

sergicastellsague commented Jan 24, 2018

yschimke commented Jan 24, 2018

kelset commented Jan 29, 2018

swankjesse commented Feb 18, 2018

anna-b commented Feb 20, 2018

kelset commented Feb 20, 2018

vasiledoe commented Jul 10, 2018 •

edited

Loading

yschimke commented Jul 10, 2018

dave-r12 commented Jul 10, 2018

TomasYu commented Jul 18, 2018

yschimke commented Jul 18, 2018

gongzelong0718 commented Jul 31, 2018

gongzelong0718 commented Jul 31, 2018

swankjesse commented Jul 31, 2018

dave-r12 commented Aug 1, 2018

chwnFlyPig commented Mar 26, 2019

Crash: Unexpected TLS version: NONE #3719

Crash: Unexpected TLS version: NONE #3719

Comments

anthony3444 commented Dec 12, 2017

yschimke commented Dec 12, 2017 • edited Loading

anthony3444 commented Dec 12, 2017

asfdfdfd commented Dec 13, 2017 • edited Loading

dgadelha commented Dec 23, 2017

yschimke commented Dec 23, 2017

anthony3444 commented Jan 9, 2018

yschimke commented Jan 10, 2018

hidroh commented Jan 22, 2018

sergicastellsague commented Jan 24, 2018

yschimke commented Jan 24, 2018

kelset commented Jan 29, 2018

swankjesse commented Feb 18, 2018

anna-b commented Feb 20, 2018

kelset commented Feb 20, 2018

vasiledoe commented Jul 10, 2018 • edited Loading

yschimke commented Jul 10, 2018

dave-r12 commented Jul 10, 2018

TomasYu commented Jul 18, 2018

yschimke commented Jul 18, 2018

gongzelong0718 commented Jul 31, 2018

gongzelong0718 commented Jul 31, 2018

swankjesse commented Jul 31, 2018

dave-r12 commented Aug 1, 2018

chwnFlyPig commented Mar 26, 2019

yschimke commented Dec 12, 2017 •

edited

Loading

asfdfdfd commented Dec 13, 2017 •

edited

Loading

vasiledoe commented Jul 10, 2018 •

edited

Loading