New API for iterating DiskLruCache contents. #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
force-pushed
the
jwilson_1229_cache_iterator
branch
from
4c3aba6
to
7d1d1b0
Compare
| while (delegate.hasNext()) { | ||
| Entry entry = delegate.next(); | ||
| Snapshot snapshot = entry.snapshot(); | ||
| if (snapshot == null) continue; // Evicted since we created copied the entries. |
There was a problem hiding this comment.
Double verb in comment.
There was a problem hiding this comment.
Fixed. I need something like type safety for my English grammar.
|
checkstyle, otherwise LGTM. I like the simplicity of the api and omit vs exception bias |
|
LGTM! |
swankjesse
force-pushed
the
jwilson_1229_cache_iterator
branch
from
7d1d1b0
to
755bd91
Compare
swankjesse
added a commit
that referenced
this pull request
Dec 29, 2014
New API for iterating DiskLruCache contents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #853