Embed the public suffix database list directly inside a class

[yschimke]

Attempt a fix for #8580

Removes the need for proguard for the database. At the cost of more costly code generation at build time.

Point at which we parse the file

java.lang.Exception
	at okhttp3.internal.publicsuffix.EmbeddedPublicSuffixList.<clinit>(EmbeddedPublicSuffixList.kt:35)
	at okhttp3.internal.publicsuffix.PublicSuffixDatabase.<clinit>(PublicSuffixDatabase.kt:157)
	at okhttp3.Cookie$Companion.parse$okhttp(Cookie.kt:561)
	at okhttp3.Cookie$Companion.parse(Cookie.kt:450)
	at okhttp3.CookiesTest.acceptOriginalServerMatchesSubdomain(CookiesTest.kt:306)

Generated source looks like, and both the source and class file are 57KB.

  override val bytes: ByteString = "Y2l0eS5rYXdhc2FraS5qcApjaXR5LmtpdGFreXVzaHUuanAKY2l0eS5rb2JlLmpwCmNpdHkubmFnb3lhLmpwCmNpdHkuc2FwcG9yby5qcApjaXR5LnNlbmRhaS5qcApjaXR5Lnlva29oYW1hLmpwCnd3dy5jawo=".decodeBase64()!!

[yschimke]

Seems to kill the kotlin compiler

Maybe https://youtrack.jetbrains.com/issue/KT-72429/StackOverflowError-when-compiling-large-files

or

https://stackoverflow.com/a/60934758/1542667

[yschimke]

I shouldn't have uncompressed it. Will compare the compressed version

[JakeWharton]

I'll review the rest on desktop. Too dense for mobile.

[yschimke]

One alternative is to leave the existing implementation in src/main as the default, until we get a version that we are happy with and then switch.

[JakeWharton]

Seems like string should have an overload which takes start/end indices to avoid this double copy. Or we should have added ByteString.slice!

[yschimke]

Will raise a PR.

[JakeWharton]

How about a nullable var and setting to null once read?

[JakeWharton]

Not done in ensureLoaded?

[yschimke]

I figured the JVM classloader would be a nice simple mutex. Ther s so much locking code in the other impl

[swankjesse]

I particularly don’t like this. We shouldn’t need to degrade good user’s runtime performance and artifact sizes because bad users are clumsy and trip on every rake.

[swankjesse]

Is there a way to load resources on Android that isn’t horrible for performance?!

[yschimke]

I can benchmark

• resources
• assets
• embedded

Although my money is on this being better for performance than resources, just maybe at a small runtime memory cost.

[swankjesse]

Can we do assets on Android and resources on the JVM? OkHttp 5 can be multiplatform with just Android and JVM platforms, right?

[yschimke]

This went a bit pear shaped...

#8599

But exploring the space :)

[yschimke]

I'll check the multiplatform build option next.

[yschimke]

hopefully go with multiplatform following something like

https://jeroenmols.com/blog/2021/03/17/share-code-kotlin-multiplatform/

And avoid the com.android.library plugin

https://kotlinlang.org/docs/whatsnew2020.html#deprecated-compatibility-with-kotlin-multiplatform-gradle-plugin-and-gradle-java-plugins

[yschimke]

Made an attempt #8600

We would need that other PR above in order to get a Context to load from assets. So that other change is worth benchmarking first.