Implement Timeout.cancel for waitUntilNotified #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This triggers a 'spurious wakeup' in the case where a timeout is canceled. This is the best we can do without a discrete mechanism to distinguish between a notify() and a timeout.
|
I intend to implement Timeout.cancel() for awaitSignal(), intersectWith(), ForwardingTimeout, and AsyncTimeout in follow-up changes. |
swankjesse
commented
Dec 14, 2023
| * A sentinel that is updated to a new object on each call to [cancel]. Sample this property | ||
| * before and after an operation to test if the timeout was canceled during the operation. | ||
| */ | ||
| @Volatile private var cancelMark: Any? = null |
There was a problem hiding this comment.
I also considered doing cancelCount: Int but I think I like this better. It doesn’t have an overflow problem!
There was a problem hiding this comment.
I think it would have worked. Concurrent read, add, writes would still have changed the value. Overflowing still results in a new value. The only problem would have been if you called cancel 2^32 times during an operation it wouldn't be detected (but that's probably okay because it's impossible).
There was a problem hiding this comment.
That’s exactly the case I was considering. It’s practically impossible but ugly
yschimke
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggers a 'spurious wakeup' in the case where a timeout is canceled. This is the best we can do without a discrete mechanism to distinguish between a notify() and a timeout.