Get openZip working on KotlinNative #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Minimal zip is 22 bytes. Look at this chunker at a whopping 41!!!
JakeWharton
approved these changes
Feb 22, 2024
| @@ -97,6 +97,9 @@ kotlin { | |||
|
|
|||
| val zlibTest by creating { | |||
| dependsOn(commonTest) | |||
| dependencies { | |||
| implementation(libs.test.assertk) | |||
There was a problem hiding this comment.
I will fix this wasm problem tomorrow (although I don't control when releases happen).
There was a problem hiding this comment.
I was playing with it. I ran into this:
* What went wrong:
Execution failed for task ':assertk:wasmWasiNodeTest'.
> command '/Users/jwilson/.gradle/nodejs/node-v21.0.0-v8-canary202309143a48826a08-darwin-arm64/bin/node' exited with errors (exit code: 1)
Totally unclear what I did wrong. Trying to borrow config from Okio wasn’t helping much!
JakeWharton
reviewed
Feb 22, 2024
There was a problem hiding this comment.
We should really make this public (with a little design tweak for OkHttp). We're long-past the rule of three on it.
There was a problem hiding this comment.
Can do. Follow-up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.