Fixes onlyScaleDown() when targetWidth or targetHeight is 0 #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ShadowBitmap shadowBitmap = shadowOf(result); | ||
| assertThat(shadowBitmap.getCreatedFromBitmap()).isNull(); | ||
| assertThat(shadowBitmap.getCreatedFromBitmap()).isNotSameAs(source); |
There was a problem hiding this comment.
This test logic is wrong (it looks copy/pasted). If we already check the value is null there's no reason to check it against something else.
I suspect it was meant to be assertThat(result).isNotSameAs(source) in the original test and here it should be isSameAs.
There was a problem hiding this comment.
I took the code from onlyScaleDownOriginalSmaller() which has the same logic. Is that test faulty, too?
avsector
force-pushed
the
hm-shouldResize
branch
from
76794f9 to
24a1cf2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1432