Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SAM interfaces fun interfaces so they can be given as lambdas in Kotlin 1.4 #47

Merged
merged 2 commits into from
Aug 29, 2020

Conversation

zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Aug 18, 2020

No description provided.

@zach-klippenstein zach-klippenstein changed the title Make SAM interfaces fun interfaces so they can be given as lambdas in… Make SAM interfaces fun interfaces so they can be given as lambdas in Kotlin 1.4 Aug 18, 2020
@zach-klippenstein
Copy link
Collaborator Author

ktlint's not happy. Fix is on the way, see pinterest/ktlint#830

@zach-klippenstein
Copy link
Collaborator Author

As of #51, blocked by Kotlin 1.4 upgrade again.

@zach-klippenstein zach-klippenstein marked this pull request as draft August 20, 2020 19:01
@zach-klippenstein
Copy link
Collaborator Author

Ktlint 0.38.0 has been released with kotlin 1.4.0 support. But we need to stop using a 3P plugin to try it out.

@zach-klippenstein zach-klippenstein marked this pull request as ready for review August 29, 2020 10:11
@zach-klippenstein
Copy link
Collaborator Author

Added prefix commit to force the ktlint plugin to use ktlint version 0.38.1 and workaround #67.

@zach-klippenstein zach-klippenstein merged commit 21881be into main Aug 29, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/fun-interfaces branch August 29, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants