target Maven 3.1 #155
Merged
target Maven 3.1 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change that is not compatible with Maven < 3.1 . spoon-maven-plugin: use org.eclipse.aether instead of org.sonatype.aether . see http://maven.apache.org/docs/3.1.0/release-notes.html spoon: use android-maven-plugin 3.8.0 which is the lowest version compatible with Maven 3.1 .
| @@ -173,7 +173,7 @@ | |||
| <plugin> | |||
| <groupId>com.jayway.maven.plugins.android.generation2</groupId> | |||
| <artifactId>android-maven-plugin</artifactId> | |||
| <version>3.6.0</version> | |||
| <version>3.8.0</version> | |||
There was a problem hiding this comment.
It should be. 3.8.1 just came out. I'll make that change.
There was a problem hiding this comment.
Ahh, didn't notice this was opened a while ago.
There was a problem hiding this comment.
made the change in 66b1a7e . This pull request should fix Spoon for Maven users
|
Can you sign our CLA |
|
Just signed the CLA |
|
Thanks! |
|
Thanks for merging this. Spoon has been awesome so far. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change that is not compatible with Maven < 3.1 .
spoon-maven-plugin: use org.eclipse.aether instead of org.sonatype.aether .
see http://maven.apache.org/docs/3.1.0/release-notes.html
spoon: use android-maven-plugin 3.8.0 which is the lowest version compatible
with Maven 3.1 .
Fix issue: #152