Update grpc to v1.57.2 #2615
Merged
Update grpc to v1.57.2 #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egorand
approved these changes
Sep 6, 2023
wire-grpc-server/build.gradle.kts
Outdated
| implementation(libs.checker.qual) | ||
| implementation(libs.guava){ | ||
| attributes { | ||
| // We help Gradle pick between the jre and android of Guava. |
There was a problem hiding this comment.
Is it needed? Does Gradle resolve it to the Android version by default?
There was a problem hiding this comment.
It doesn't resolve it at all actually so I had to tell him
And others are seeing it: google/guava#6612
There was a problem hiding this comment.
I talked with @martinbonnin and we cannot repro without the attribute so I tried a commit without any of them.
There was a problem hiding this comment.
and of course it passes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.