Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/mesh: optionally prioritise private addresses #232

Merged
merged 1 commit into from
Sep 24, 2021
Merged

pkg/mesh: optionally prioritise private addresses #232

merged 1 commit into from
Sep 24, 2021

Conversation

sbaildon
Copy link
Contributor

@sbaildon sbaildon commented Aug 22, 2021 •
edited
Loading

Optionally prefer a node's external IP be set to it's private IP

If deploying a cluser to a cloud provider across regions with a shared VPC, I'd probably want my traffic to stay inside the VPC to limit any bandwidth egress charges or slower links

#229 (comment)

@sbaildon sbaildon closed this Sep 14, 2021
@squat
Copy link
Owner

squat commented Sep 15, 2021

hi @sbaildon sorry i didn't TAL at this, I didn't realize it was waiting on me because it had WIP in the title 🤦
I think this is totally the right approach. Would you consider re-opening? :)

@sbaildon
Copy link
Contributor Author

hi @sbaildon sorry i didn't TAL at this, I didn't realize it was waiting on me because it had WIP in the title 🤦
I think this is totally the right approach. Would you consider re-opening? :)

No problem. It fell off my todo shortlist, and no one likes stale PRs

@sbaildon sbaildon reopened this Sep 15, 2021
@squat
Copy link
Owner

squat commented Sep 18, 2021

This looks clean to me, can we rebase and mark as non-WIP?

@sbaildon sbaildon changed the title wip: prioritise private addresses pkg/mesh: optionally prioritise private addresses Sep 18, 2021
@sbaildon sbaildon marked this pull request as ready for review September 18, 2021 19:22
@squat
Copy link
Owner

squat commented Sep 19, 2021

What do you think @leonnicolas?

@squat squat merged commit 3174467 into squat:main Sep 24, 2021
@squat
Copy link
Owner

squat commented Sep 24, 2021

🎉🎉🎉

@sbaildon sbaildon deleted the prioritiseprivate branch September 24, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonnicolas leonnicolas leonnicolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbaildon @squat @leonnicolas