-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitHub CodeQL static analysis in CI #693
Conversation
i like this. It would be even better if the commit comment contained links or other explanations about what checks are done. These are asks, not mandatory. In any case, the more checks the better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try this
I'm not exactly sure about any of the details for this. Approval to use the scanner on Squid sources came through today and what you can see from the "Checks" tab are the logs and artifacts from the scan. From the build log (Checks -> Analyse -> "..." menu -> Raw Logs) it appears that none of the optional libraries are present. This is just a basic Ubuntu with build chain installed. |
It would be good if we could add the extra things we need :/
On Wed, 22 Jul 2020 at 13:56, Amos Jeffries ***@***.***> wrote:
I'm not exactly sure about any of the details for this. Approval to use
the scanner on Squid sources came through today and what you can see from
the "Checks" tab are the logs and artifacts from the scan.
From the build log (Checks -> Analyse -> "..." menu -> Raw Logs) it
appears that none of the optional libraries are present. This is just a
basic Ubuntu with build chain installed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#693 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHPVDBDOIRLVTDWXBLUBFLR43HXPANCNFSM4PEJQOIA>
.
--
@mobile
|
had to go with this because the other names have conflicts Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions, but I do not insist on further changes.
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.